Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore docker and podman auth info if deserialization failed #75

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Ignore docker and podman auth info if deserialization failed #75

merged 1 commit into from
Sep 13, 2022

Conversation

termoshtt
Copy link
Owner

@termoshtt termoshtt commented Sep 13, 2022 •
edited
Loading

Problem

For example, $HOME/.docker/config.json on Windows runner of GitHub Actions is following:

{
	"auths": {
		"https://index.docker.io/v1/": {}
	},
	"credsStore": "wincred"
}

Current implementation of ocipkg will fail if this config.json exists with

Error: InvalidJson(Error("missing field `auth`", line: 3, column: 35))

https://github.com/rust-math/rust-mkl-container/actions/runs/3038006115/jobs/4891157780

How to fix

This PR simply ignores such config.json which cause deserialization error.

@termoshtt termoshtt added the bug Fix bug. label Sep 13, 2022
@termoshtt termoshtt self-assigned this Sep 13, 2022
@termoshtt termoshtt marked this pull request as ready for review September 13, 2022 02:43
@termoshtt termoshtt merged commit 59333ed into main Sep 13, 2022
@termoshtt termoshtt deleted the accept-more-auth-json branch September 13, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@termoshtt termoshtt

Labels
bug Fix bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@termoshtt